|
1 |
| package net.sourceforge.pmd.rules.strictexception; |
|
2 |
| |
|
3 |
| import net.sourceforge.pmd.AbstractRule; |
|
4 |
| import net.sourceforge.pmd.ast.ASTCompilationUnit; |
|
5 |
| import net.sourceforge.pmd.ast.ASTConstructorDeclaration; |
|
6 |
| import net.sourceforge.pmd.ast.ASTImportDeclaration; |
|
7 |
| import net.sourceforge.pmd.ast.ASTMethodDeclaration; |
|
8 |
| import net.sourceforge.pmd.ast.ASTName; |
|
9 |
| import net.sourceforge.pmd.ast.Node; |
|
10 |
| |
|
11 |
| import java.util.Iterator; |
|
12 |
| import java.util.List; |
|
13 |
| |
|
14 |
| |
|
15 |
| |
|
16 |
| |
|
17 |
| |
|
18 |
| |
|
19 |
| |
|
20 |
| |
|
21 |
| public class ExceptionSignatureDeclaration extends AbstractRule { |
|
22 |
| |
|
23 |
| private boolean junitImported; |
|
24 |
| |
|
25 |
7
| public Object visit(ASTCompilationUnit node, Object o) {
|
|
26 |
7
| junitImported = false;
|
|
27 |
7
| return super.visit(node, o);
|
|
28 |
| } |
|
29 |
| |
|
30 |
2
| public Object visit(ASTImportDeclaration node, Object o) {
|
|
31 |
2
| if (node.getImportedName().indexOf("junit") != -1) {
|
|
32 |
2
| junitImported = true;
|
|
33 |
| } |
|
34 |
2
| return super.visit(node, o);
|
|
35 |
| } |
|
36 |
| |
|
37 |
6
| public Object visit(ASTMethodDeclaration methodDeclaration, Object o) {
|
|
38 |
6
| if ((methodDeclaration.getMethodName().equals("setUp") || methodDeclaration.getMethodName().equals("tearDown")) && junitImported) {
|
|
39 |
2
| return super.visit(methodDeclaration, o);
|
|
40 |
| } |
|
41 |
| |
|
42 |
4
| if (methodDeclaration.getMethodName().startsWith("test")) {
|
|
43 |
1
| return super.visit(methodDeclaration, o);
|
|
44 |
| } |
|
45 |
| |
|
46 |
3
| List exceptionList = methodDeclaration.findChildrenOfType(ASTName.class);
|
|
47 |
3
| if (!exceptionList.isEmpty()) {
|
|
48 |
1
| evaluateExceptions(exceptionList, o);
|
|
49 |
| } |
|
50 |
3
| return super.visit(methodDeclaration, o);
|
|
51 |
| } |
|
52 |
| |
|
53 |
| |
|
54 |
1
| public Object visit(ASTConstructorDeclaration constructorDeclaration, Object o) {
|
|
55 |
1
| List exceptionList = constructorDeclaration.findChildrenOfType(ASTName.class);
|
|
56 |
1
| if (!exceptionList.isEmpty()) {
|
|
57 |
1
| evaluateExceptions(exceptionList, o);
|
|
58 |
| } |
|
59 |
1
| return super.visit(constructorDeclaration, o);
|
|
60 |
| } |
|
61 |
| |
|
62 |
| |
|
63 |
| |
|
64 |
| |
|
65 |
| |
|
66 |
| |
|
67 |
| |
|
68 |
2
| private void evaluateExceptions(List exceptionList, Object context) {
|
|
69 |
2
| ASTName exception;
|
|
70 |
2
| for (Iterator iter = exceptionList.iterator(); iter.hasNext();) {
|
|
71 |
2
| exception = (ASTName) iter.next();
|
|
72 |
2
| if (hasDeclaredExceptionInSignature(exception)) {
|
|
73 |
2
| addViolation(context, exception);
|
|
74 |
| } |
|
75 |
| } |
|
76 |
| } |
|
77 |
| |
|
78 |
| |
|
79 |
| |
|
80 |
| |
|
81 |
| |
|
82 |
| |
|
83 |
| |
|
84 |
| |
|
85 |
2
| private boolean hasDeclaredExceptionInSignature(ASTName exception) {
|
|
86 |
2
| return exception.hasImageEqualTo("Exception") && isParentSignatureDeclaration(exception);
|
|
87 |
| } |
|
88 |
| |
|
89 |
| |
|
90 |
| |
|
91 |
| |
|
92 |
| |
|
93 |
2
| private boolean isParentSignatureDeclaration(ASTName exception) {
|
|
94 |
2
| Node parent = exception.jjtGetParent().jjtGetParent();
|
|
95 |
2
| return parent instanceof ASTMethodDeclaration || parent instanceof ASTConstructorDeclaration;
|
|
96 |
| } |
|
97 |
| |
|
98 |
| } |